fix(helm): Fix statefulset templates to not show diffs in ArgoCD

[sviatlo]

What this PR does / why we need it:
This PR fixes PersistentVolumeClaim definition in statefulset templates for various apps to avoid diffs in ArgoCD.

Checklist

• Reviewed the CONTRIBUTING.md guide (required)
• Documentation added
• Tests updated
• Title matches the required conventional commits format, see here
  • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
• Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
• If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

[CLAassistant]

All committers have signed the CLA.

[sviatlo]

Hi @trevorwhitney! Sorry to ping you like that, but I saw that you have reviewed a loki/helm PR recently and thought to ask you to take a look at this PR when you will have time. Thanks in advance!

[trevorwhitney]

thanks for the contribution. can you explain how this change fixes your problem of diffs in ArgoCD? have you considered any other approaches that would allow a user, such as yourself, to template in the changes they need for their CD env without changing the defaults for everyone, or can you explain why everyone would benefit from this change?

[sviatlo]

This is the diff in argocd:

The cause of the diff is that argocd reads k8s resource that has these fields set and compares it to a manifest generated from the helm chart where the fields are omitted as a shorthand. I can technically ignore this diff in argocd, but I don't see a reason why not to fix this upstream.
You can see the same changes done in mimir and tempo charts: mimir, tempo.

[github-actions]

Kubernetes Manifest Diff Summary

Scenario: default-single-binary-values (Added: 0, Modified: 0, Removed: 0)

Summary:

• Added: 0

• Modified: 0

• Removed: 0

Added Files

No added files

Modified Files

No modified files

Removed Files

No removed files

Scenario: default-values (Added: 0, Modified: 0, Removed: 0)

Summary:

• Added: 0

• Modified: 0

• Removed: 0

Added Files

No added files

Modified Files

No modified files

Removed Files

No removed files

Scenario: ingress-values (Added: 0, Modified: 0, Removed: 0)

Summary:

• Added: 0

• Modified: 0

• Removed: 0

Added Files

No added files

Modified Files

No modified files

Removed Files

No removed files

Scenario: legacy-monitoring-values (Added: 0, Modified: 0, Removed: 0)

Summary:

• Added: 0

• Modified: 0

• Removed: 0

Added Files

No added files

Modified Files

No modified files

Removed Files

No removed files

Scenario: simple-scalable-aws-kube-irsa-values (Added: 0, Modified: 0, Removed: 0)

Summary:

• Added: 0

• Modified: 0

• Removed: 0

Added Files

No added files

Modified Files

No modified files

Removed Files

No removed files

[trevorwhitney]

thanks for the explanation and examples from tempo and mimir. lgtm!