Skip to content

Conversation

@trevorwhitney
Copy link
Collaborator

What this PR does / why we need it:

Allows query comparisons against zero bytes, ie {foo="bar"} | logfmt | bytes < 0b.

Which issue(s) this PR fixes:
Fixes #14993

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@trevorwhitney trevorwhitney requested a review from a team as a code owner December 2, 2024 23:43
Co-authored-by: George Robinson <george.robinson@grafana.com>
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trevorwhitney trevorwhitney merged commit 17f1972 into main Dec 6, 2024
58 checks passed
@trevorwhitney trevorwhitney deleted the fix-0b-parsing branch December 6, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 participants