feat(blockbuilder): grpc transport #15218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashwanthgoli
approved these changes
Dec 3, 2024
|
|
||
| var _ Transport = &GRPCTransport{} | ||
|
|
||
| type GRPCTransportConfig struct { |
There was a problem hiding this comment.
nit: should we embed this in builder config? ignore me if it is planned for a follow-up
There was a problem hiding this comment.
Yeah, I planned to leave this for when we're ready to wire it together.
| type GRPCTransportConfig struct { | ||
| Address string `yaml:"address,omitempty"` | ||
|
|
||
| // GRPCClientConfig configures the gRPC connection between the Bloom Gateway client and the server. |
There was a problem hiding this comment.
Suggested change
| // GRPCClientConfig configures the gRPC connection between the Bloom Gateway client and the server. | |
| // GRPCClientConfig configures the gRPC connection between the block builder client and the scheduler. |
This was referenced Dec 23, 2024
This was referenced Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gRPC transport implementation as defined in https://github.com/grafana/loki/blob/c1ca06793d561a708fa9ff38f7e2fc012c90b064/pkg/blockbuilder/architecture.md