Skip to content

Conversation

@trevorwhitney
Copy link
Collaborator

What this PR does / why we need it:

Metric aggregation was move to a per-tenant config. #15059 removed the old global config, but forgot to add the new limit override. This adds the limit override to loki-local-config.yaml so that metric aggregation is enabled in that config.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@trevorwhitney trevorwhitney requested a review from a team as a code owner December 6, 2024 16:35
@trevorwhitney trevorwhitney added type/bug Somehing is not working as expected backport release-3.3.x labels Dec 9, 2024
@loki-gh-app
Copy link
Contributor

loki-gh-app bot commented Dec 9, 2024

This PR must be merged before a backport PR will be created.

1 similar comment
@loki-gh-app
Copy link
Contributor

loki-gh-app bot commented Dec 9, 2024

This PR must be merged before a backport PR will be created.

@trevorwhitney trevorwhitney changed the title chore: enable metric aggregation in loki-local-config.yaml Dec 9, 2024
@trevorwhitney trevorwhitney merged commit c96b750 into main Dec 9, 2024
64 checks passed
@trevorwhitney trevorwhitney deleted the metric-aggregation-in-loki-local branch December 9, 2024 18:46
loki-gh-app bot pushed a commit that referenced this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport release-3.3.x size/XS type/bug Somehing is not working as expected

2 participants