Skip to content

feat(api): Support Parquet as a query response format. #15408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Dec 18, 2024
Merged

feat(api): Support Parquet as a query response format. #15408

merged 14 commits into from
Dec 18, 2024

Conversation

@jeschkies
Copy link
Contributor

@jeschkies jeschkies commented Dec 13, 2024 •
edited
Loading

What this PR does / why we need it:
This changes adds support for the header Accept: application/vnd.apacher.parquet. If this header is set the response for metric and stream queries will response with a Parquet file.

A metrics response has the columns timestamp, labels and value. A stream response has the columns timestamp, labels and line.

The Parquet file can be queried with e.g. DuckDB:
render1734096279010-min

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@jeschkies jeschkies requested a review from a team as a code owner December 13, 2024 13:57
@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Dec 13, 2024
@jeschkies jeschkies requested a review from JStickler December 13, 2024 14:27
chaudum
chaudum reviewed Dec 16, 2024
View reviewed changes
Copy link
Contributor

@chaudum chaudum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
chaudum
chaudum reviewed Dec 16, 2024
View reviewed changes
chaudum
chaudum approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@chaudum chaudum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Waiting for @JStickler for docs review.
JStickler
JStickler approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Waiting for @JStickler for docs review.

[docs team] docs updates LGTM
@jeschkies jeschkies merged commit d0c11a6 into grafana:main Dec 18, 2024
62 of 63 checks passed
@jeschkies jeschkies deleted the karsten/parquet-output branch December 18, 2024 15:29
This was referenced Dec 23, 2024
Closed
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Jan 6, 2025
Closed
mveitas pushed a commit to mveitas/loki that referenced this pull request Jan 6, 2025
@jeschkies @chaudum @matt-veitas-eb
feat(api): Support Parquet as a query response format. (grafana#15408)
6621d2c 
**What this PR does / why we need it**:
This changes adds support for the header `Accept: application/vnd.apacher.parquet`. If this header is set the response for metric and stream queries will response with a Parquet file.

A metrics response has the columns `timestamp`, `labels` and `value`. A stream response has the columns `timestamp`, `labels` and `line`.

Co-authored-by: Christian Haudum <christian.haudum@gmail.com>
@loki-gh-app loki-gh-app bot mentioned this pull request Jan 13, 2025
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Jan 20, 2025
Closed
This was referenced Feb 3, 2025
Closed
Merged
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Feb 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XXL type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories

3 participants

@jeschkies @chaudum @JStickler