Skip to content

Conversation

@cyriltovena
Copy link
Contributor

What this PR does / why we need it:

This allows to bypass template format execution if this is a simple swap of the line with another key. Making that trick faster to use.

{bar="foo"} | json | line_format `{{.message}}` | pattern "<_>: <_> <something>" ....

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@cyriltovena cyriltovena requested a review from a team as a code owner December 13, 2024 17:25
Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a comment suggestion to help explain what's being done, otherwise LGTM

Co-authored-by: Ed Welch <ed@edjusted.com>
@cyriltovena cyriltovena merged commit 2150fbc into grafana:main Dec 16, 2024
58 checks passed
mveitas pushed a commit to mveitas/loki that referenced this pull request Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants