Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): Downgrade hyperloglog to 0.2.0 (#15424) #15426

Merged
merged 1 commit into from
Dec 16, 2024
Merged

fix(deps): Downgrade hyperloglog to 0.2.0 (#15424) #15426

merged 1 commit into from
Dec 16, 2024

Conversation

chaudum
Copy link
Contributor

@chaudum chaudum commented Dec 16, 2024

What this PR does / why we need it:

CI fails with error

180.2 vendor/github.com/kamstrup/intmap/map64.go:22:11: 0x9E3779B9 (untyped int constant 2654435769) overflows int

Special notes for your reviewer:

This PR reverts: #15322
@chaudum chaudum requested a review from a team as a code owner December 16, 2024 10:25
shantanualsi
shantanualsi approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@shantanualsi shantanualsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
fcjack
fcjack approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@fcjack fcjack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@chaudum chaudum merged commit 3b0d815 into main Dec 16, 2024
63 checks passed
@chaudum chaudum deleted the chaudum/revert-hll branch December 16, 2024 11:14
This was referenced Dec 23, 2024
Closed
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Jan 6, 2025
Closed
mveitas pushed a commit to mveitas/loki that referenced this pull request Jan 6, 2025
@chaudum @shantanualsi @mveitas
fix(deps): Downgrade hyperloglog to 0.2.0 (grafana#15424) (grafana#15426
8b171a6 
)

Co-authored-by: Shantanu Alshi <shantanu.alshi@grafana.com>
@loki-gh-app loki-gh-app bot mentioned this pull request Jan 13, 2025
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Jan 20, 2025
Closed
This was referenced Feb 3, 2025
Closed
Merged
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Feb 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S
3 participants
@chaudum @shantanualsi @fcjack