Skip to content

Conversation

@trevorwhitney
Copy link
Collaborator

What this PR does / why we need it:

DF field values are currently turning all numeric fields into bytes, this is a bug. This fixes that bug.

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@trevorwhitney trevorwhitney requested a review from a team as a code owner December 20, 2024 20:25
@trevorwhitney trevorwhitney merged commit 8e260fe into main Jan 4, 2025
60 checks passed
@trevorwhitney trevorwhitney deleted the fix-df-byte-detection branch January 4, 2025 00:17
mveitas pushed a commit to mveitas/loki that referenced this pull request Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants