fix: do not retain copy of chunk while indexing a new chunk in tsdb while processing delete requests #15541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…processing delete requests
paul1r
approved these changes
Dec 31, 2024
mveitas
pushed a commit
to mveitas/loki
that referenced
this pull request
Jan 6, 2025
…hile processing delete requests (grafana#15541)
This was referenced Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We might have new chunks created while processing delete requests, especially with line filters. The new chunks are then indexed for discoverability. The thing to note here is that TSDB index is not built incrementally and requires all the data at once to build it. This TSDB limitation caused us to batch the updates, which in this case, resulted in increased memory usage due to erroneously retaining a copy of a chunk instead of just the metadata. This PR fixes the issue by batching chunk metas instead of whole chunks.