Skip to content

Conversation

@ashwanthgoli
Copy link
Contributor

@ashwanthgoli ashwanthgoli commented Dec 26, 2024

What this PR does / why we need it:
Record decoder reuses the stream and entries slice, this would not be a problem if these entries are consumed synchronously. But the block builder buffers the entries and consumes them in batches through a channel while the decoder reuses the entries slice on each decode call.
Making a copy of the entries to avoid this problem.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@ashwanthgoli ashwanthgoli marked this pull request as ready for review December 27, 2024 13:09
@ashwanthgoli ashwanthgoli requested a review from a team as a code owner December 27, 2024 13:09
Copy link
Member

@owen-d owen-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

@owen-d owen-d merged commit 52d745f into main Dec 27, 2024
60 checks passed
@owen-d owen-d deleted the fix-blockbuilder-decode branch December 27, 2024 17:13
mveitas pushed a commit to mveitas/loki that referenced this pull request Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants