fix(block-scheduler): one job per partition (local branch copy) #15579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type/docs
|
💻 Deploy preview deleted. |
ashwanthgoli
reviewed
Jan 3, 2025
|
|
||
| // find first job for this partition | ||
| nextJob := sort.Search(len(jobs), func(i int) bool { | ||
| return jobs[i].Job.Partition() >= job.Partition() |
There was a problem hiding this comment.
Suggested change
| return jobs[i].Job.Partition() >= job.Partition() | |
| return jobs[i].Job.Partition() == job.Partition() |
There was a problem hiding this comment.
That function probably works a bit different than you think :)
ashwanthgoli
reviewed
Jan 3, 2025
| }) | ||
|
|
||
| if nextJob < len(jobs) { | ||
| _, _, _ = s.idempotentEnqueue(jobs[nextJob]) |
There was a problem hiding this comment.
there is a potential race here that could result in this operation to fail as we try to enqueue the same job from two different routines (from HandleCompleteJob or from the scheduler run loop). but this might not cause any problems
There was a problem hiding this comment.
This should be ok since the enqueue code first checks the statusmap for existence of a job before adding it to the queue. We may need to introduce some error handling here or there to swallow these cases, but it shouldn't be possible to add duplicate jobs at the moment.
mveitas
pushed a commit
to mveitas/loki
that referenced
this pull request
Jan 6, 2025
This was referenced Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Local branch copy of #15578 to debug possible fork permission issues
max_jobs_planned_per_interval. We don't want this yet and it was being used incorrectly as the plannersmaxJobsPerPartitionargument.Some of it is a bit hacky & will need refactoring, but this should work well enough in the meantime to flesh out issues.