feat(block-scheduler): status page shows completed jobs #15580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashwanthgoli
reviewed
Jan 3, 2025
ashwanthgoli
reviewed
Jan 3, 2025
|
|
||
| // TestPreview is a utility test that runs a local server with the status page. | ||
| // Run it with: go test -tags=preview -v -run TestPreview | ||
| func TestPreview(t *testing.T) { |
There was a problem hiding this comment.
nit: i guess we could just remove status_test.go since this is a better way to preview the page
Co-authored-by: Ashwanth <iamashwanth@gmail.com> Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
mveitas
pushed a commit
to mveitas/loki
that referenced
this pull request
Jan 6, 2025
Signed-off-by: Owen Diehl <ow.diehl@gmail.com> Co-authored-by: Ashwanth <iamashwanth@gmail.com>
This was referenced Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scheduler keeps a circular buffer of the last
ncompleted jobs. This PR now includes this information in the status page for easier tracking of system behavior. it also adds a test utility to play around with this locally. Here's an example: