Skip to content

fix(typo): Change "did received" to "did receive" in NOTES.txt #15584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 6, 2025
Merged

fix(typo): Change "did received" to "did receive" in NOTES.txt #15584

merged 3 commits into from
Jan 6, 2025

Conversation

@louisdtt
Copy link
Contributor

@louisdtt louisdtt commented Jan 3, 2025 •
edited
Loading

What this PR does / why we need it: Fix for a typo in NOTES.txt

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@louisdtt
fix(typo): Change "did received" to "did receive" in NOTES.txt
6a5a5c4 
Signed-off-by: Louis Dutoit <39375035+louisdtt@users.noreply.github.com>
@louisdtt louisdtt requested a review from a team as a code owner January 3, 2025 14:01
@CLAassistant
Copy link

CLAassistant commented Jan 3, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.
JStickler
JStickler approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[docs team] LGTM.
@JStickler JStickler merged commit 9191eaf into grafana:main Jan 6, 2025
60 checks passed
@louisdtt louisdtt deleted the patch-1 branch January 6, 2025 18:13
@loki-gh-app loki-gh-app bot mentioned this pull request Jan 13, 2025
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Jan 20, 2025
Closed
This was referenced Feb 3, 2025
Closed
Merged
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Feb 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/helm size/XS

3 participants

@louisdtt @CLAassistant @JStickler