Skip to content

fix: Fix loki ruler generator url left parameter url encoding #15601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 9, 2025
Merged

fix: Fix loki ruler generator url left parameter url encoding #15601

merged 1 commit into from
Jan 9, 2025
+5 −5

Conversation

@matthewhudsonedb
Copy link
Contributor

@matthewhudsonedb matthewhudsonedb commented Jan 6, 2025 •
edited
Loading

What this PR does / why we need it:
The generate URL left parameter is not URL encoded. The double quotes in str variable around "queries" break hyperlinking.

Which issue(s) this PR fixes:
Fixes #15597

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@matthewhudsonedb matthewhudsonedb requested a review from a team as a code owner January 6, 2025 09:06
@CLAassistant
Copy link

CLAassistant commented Jan 6, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.
chaudum
chaudum approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@chaudum chaudum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGMT
@chaudum
Copy link
Contributor

chaudum commented Jan 8, 2025

@matthewhudsonedb Can you please update the failing test cases?
@pull-request-size pull-request-size bot added size/S and removed size/XS labels Jan 9, 2025
@matthewhudsonedb matthewhudsonedb force-pushed the main branch 5 times, most recently from eac6626 to 709884c Compare January 9, 2025 04:02
@matthewhudsonedb
Copy link
Contributor Author

@chaudum test cases have been updated. thx.
@chaudum chaudum merged commit e347eb7 into grafana:main Jan 9, 2025
59 checks passed
@loki-gh-app loki-gh-app bot mentioned this pull request Jan 13, 2025
Closed
@LukoJy3D LukoJy3D mentioned this pull request Jan 13, 2025
Closed
3 tasks
@loki-gh-app loki-gh-app bot mentioned this pull request Jan 20, 2025
Closed
This was referenced Feb 3, 2025
Closed
Merged
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Feb 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S

3 participants

@matthewhudsonedb @CLAassistant @chaudum