feat(logcli): Include common labels - #15611
Merged
Merged
Conversation
Adds a new `--include-common-labels` flag to `logcli query`, which causes the output to include all common labels. This is mostly useful with `--quiet` and `--output=jsonl` as it allows users to get structured information from Loki that has *all* the information that Loki can provide. Fixes grafana#5702
|
|
chaudum
reviewed
Jan 8, 2025
chaudum
left a comment
chaudum
left a comment
Contributor
There was a problem hiding this comment.
One minor suggestion regarding flag help text, but otherwise LGMT. Thanks!
Co-authored-by: Christian Haudum <christian.haudum@gmail.com> Signed-off-by: Jonathan Lange <jml@mumak.net>
chaudum
approved these changes
Jan 8, 2025
This was referenced Feb 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds a new
--include-common-labelsflag tologcli query, which causes the output to include all common labels.This is mostly useful with
--quietand--output=jsonlas it allows users to get structured information from Loki that has all the information that Loki can provide.Which issue(s) this PR fixes:
Fixes #5702
Special notes for your reviewer:
--all-labels. Given there are other label selection options, I thought it was easiest to add something to directly control the behaviour to remove common labels.Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR