Skip to content

fix: don't send empty aggregated metric payloads (backport k237) #15810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

loki-gh-app[bot]
Copy link
Contributor

@loki-gh-app loki-gh-app bot commented Jan 16, 2025

Backport 86d50ad from #15756


What this PR does / why we need it:

Prevent the pattern ingester from sending empty aggregated metric payloads when there are no aggregated metrics to send.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@loki-gh-app loki-gh-app bot added the backport label Jan 16, 2025
@loki-gh-app loki-gh-app bot requested a review from a team as a code owner January 16, 2025 23:48
@loki-gh-app loki-gh-app bot added size/S type/bug Somehing is not working as expected labels Jan 16, 2025
@loki-gh-app loki-gh-app bot requested a review from trevorwhitney January 16, 2025 23:48
@trevorwhitney trevorwhitney merged commit 2b5a190 into k237 Jan 16, 2025
65 checks passed
@trevorwhitney trevorwhitney deleted the backport-15756-to-k237 branch January 16, 2025 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport size/S type/bug Somehing is not working as expected
1 participant