fix: Determine when all logs have been filtered #16073
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DylanGuedes
approved these changes
Feb 3, 2025
salvacorts
pushed a commit
that referenced
this pull request
Feb 12, 2025
This was referenced Mar 20, 2025
This was referenced Mar 31, 2025
This was referenced Apr 14, 2025
This was referenced Apr 23, 2025
This was referenced May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adaptive Logs filters logs in Loki's push path. There can be the case where all logs are filtered resulting in an empty push request. This PR made empty push requests a validation error which means that some users are seeing push errors related to Adaptive Logs
The request parser here is keeping interesting statistics that we'd like to keep so This PR introduces a new error
ErrAllLogsFilteredthat can be returned from the parser. When that error is seen, Loki returns a204directly to the user without passing the push request to the distributor.