Skip to content

fix: export ExcludedMetadataLabels so it can be extended in GEL #16083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sherinabr
Copy link
Contributor

What this PR does / why we need it:
This PR exports ExcludedMetadataLabels so it can be extended in GEL for any other labels(eg. Adaptive Logs) that need to be accounted for while computing metadata size.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@sherinabr sherinabr requested a review from a team as a code owner February 4, 2025 13:55
@vlad-diachenko vlad-diachenko merged commit 9d84a68 into main Feb 4, 2025
60 checks passed
@vlad-diachenko vlad-diachenko deleted the sherin/export-structured-metadata-excluded-labels branch February 4, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 participants