Skip to content

fix: Make policy test non-flaky #16158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2025
Merged

fix: Make policy test non-flaky #16158

merged 1 commit into from
Feb 10, 2025

Conversation

DylanGuedes
Copy link
Contributor

What this PR does / why we need it:
This test scenario I'm fixing is flaky because it assumes items will appear in a specific order but Go doesn't guarantee that (it actually randomizes them by design).

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@DylanGuedes DylanGuedes requested a review from a team as a code owner February 10, 2025 13:05
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DylanGuedes DylanGuedes merged commit 41d9c8b into main Feb 10, 2025
59 checks passed
@DylanGuedes DylanGuedes deleted the fix-flaky-test branch February 10, 2025 15:27
salvacorts pushed a commit that referenced this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 participants