Skip to content

feat: Helm: Add extraContainers to backend pods #16205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 7, 2025
Merged

feat: Helm: Add extraContainers to backend pods #16205

merged 3 commits into from
Mar 7, 2025

Conversation

mgbz89
Copy link
Contributor

@mgbz89 mgbz89 commented Feb 12, 2025

What this PR does / why we need it:
This PR adds the extraContainers property to the backend Loki pods for the Loki helm chart.

Which issue(s) this PR fixes:
Fixes #16164

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@mgbz89 mgbz89 requested a review from a team as a code owner February 12, 2025 02:27
@CLAassistant
Copy link

CLAassistant commented Feb 12, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.
@github-actions github-actions bot added area/helm type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories labels Feb 12, 2025
@mgbz89 mgbz89 force-pushed the mgbz89/add-extra-containers-to-backend branch from 816a4f9 to 0f83a32 Compare February 12, 2025 02:29
DylanGuedes
DylanGuedes approved these changes Mar 7, 2025
View reviewed changes
Copy link
Contributor

@DylanGuedes DylanGuedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
@DylanGuedes DylanGuedes merged commit 528a1c6 into grafana:main Mar 7, 2025
70 checks passed
JoaoBraveCoding pushed a commit to JoaoBraveCoding/loki that referenced this pull request Mar 12, 2025
@mgbz89 @JoaoBraveCoding
feat: Helm: Add extraContainers to backend pods (grafana#16205)
3744a76 
**What this PR does / why we need it**:
This PR adds the `extraContainers` property to the backend Loki pods for the Loki helm chart.

**Which issue(s) this PR fixes**:
Fixes grafana#16164
This was referenced Mar 20, 2025
Open
Open
This was referenced Mar 31, 2025
Merged
Open
This was referenced Apr 14, 2025
Open
Open
@loki-gh-app loki-gh-app bot mentioned this pull request Apr 22, 2025
Open
This was referenced Apr 23, 2025
Merged
Merged
Merged
This was referenced May 5, 2025
Open
Open
This was referenced May 19, 2025
Open
Open
This was referenced May 26, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/helm size/S type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
3 participants
@mgbz89 @CLAassistant @DylanGuedes