-
Notifications
You must be signed in to change notification settings - Fork 3.7k
fix(docs): add a note on docker configuration.md doc to explain accep… #16299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ted values for boolean type refering to issue grafana#16014
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[docs team] Thanks for taking the time to update the docs. Sorry it took me so long to get to the review, I was on vacation.
@amirmotlagh Have you signed the CLA? Or possibly you've submitted this PR under a different email address than the one you've signed the CLA with? |
The email address was not as same as my github email address. Now it is signed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[docs team] LGTM, I'll just remove one unnecessary character and then merge.
Removing unnecessary character which may break the note formatting. Signed-off-by: J Stickler <julie.stickler@grafana.com>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-16299-to-release-3.3.x origin/release-3.3.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 2071a5098b4e5214fb8f8c646ae0081b39a563af When the conflicts are resolved, stage and commit the changes:
If you have the GitHub CLI installed: # Push the branch to GitHub:
git push --set-upstream origin backport-16299-to-release-3.3.x
# Create the PR body template
PR_BODY=$(gh pr view 16299 --json body --template 'Backport 2071a5098b4e5214fb8f8c646ae0081b39a563af from #16299{{ "\n\n---\n\n" }}{{ index . "body" }}')
# Create the PR on GitHub
echo "${PR_BODY}" | gh pr create --title 'fix(docs): add a note on docker configuration.md doc to explain accep… (backport release-3.3.x)' --body-file - --label 'size/L' --label 'type/docs' --label 'backport' --base release-3.3.x --milestone release-3.3.x --web Or, if you don't have the GitHub CLI installed (we recommend you install it!): # Push the branch to GitHub:
git push --set-upstream origin backport-16299-to-release-3.3.x
# Create a pull request where the `base` branch is `release-3.3.x` and the `compare`/`head` branch is `backport-16299-to-release-3.3.x`.
# Remove the local backport branch
git switch main
git branch -D backport-16299-to-release-3.3.x |
…ted values for boolean type refering to issue #16014
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #16014
Special notes for your reviewer:
Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
deprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR