feat: add a config option for custom GCS endpoints - #16419
Merged
Conversation
Contributor
|
💻 Deploy preview deleted. |
na--
enabled auto-merge (squash)
February 24, 2025 11:43
loki-gh-app Bot
pushed a commit
that referenced
this pull request
Feb 24, 2025
(cherry picked from commit f1ebd97)
6 tasks
This was referenced Mar 20, 2025
This was referenced Mar 31, 2025
This was referenced Apr 14, 2025
This was referenced Apr 23, 2025
This was referenced May 5, 2025
This was referenced May 19, 2025
This was referenced May 26, 2025
salvacorts
pushed a commit
that referenced
this pull request
Jul 11, 2025
(cherry picked from commit f1ebd97)
salvacorts
added a commit
that referenced
this pull request
Jul 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This allows users to specify a custom endpoint for GCS buckets, which might be necessary for users to comply with data locality regulations by using custom regional endpoints.
Special notes for your reviewer:
This doesn't work if the thanos objstore client is used instead, that will be tackled in a separate PR. It should be safe to add in separate PRs because the GCS configs are different in either case.
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR