Skip to content

feat: add a config option for custom GCS endpoints - #16419

Merged
na-- merged 1 commit into
mainfrom
custom-gcs-endpoint
Feb 24, 2025
Merged

feat: add a config option for custom GCS endpoints#16419
na-- merged 1 commit into
mainfrom
custom-gcs-endpoint

Conversation

@na--

@na-- na-- commented Feb 24, 2025

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

This allows users to specify a custom endpoint for GCS buckets, which might be necessary for users to comply with data locality regulations by using custom regional endpoints.

Special notes for your reviewer:

This doesn't work if the thanos objstore client is used instead, that will be tackled in a separate PR. It should be safe to add in separate PRs because the GCS configs are different in either case.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@na--
na-- requested a review from a team as a code owner February 24, 2025 11:34
@github-actions github-actions Bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Feb 24, 2025
@github-actions

github-actions Bot commented Feb 24, 2025

Copy link
Copy Markdown
Contributor

💻 Deploy preview deleted.

@ashwanthgoli ashwanthgoli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@na--
na-- enabled auto-merge (squash) February 24, 2025 11:43
@na--
na-- merged commit f1ebd97 into main Feb 24, 2025
@na--
na-- deleted the custom-gcs-endpoint branch February 24, 2025 12:11
loki-gh-app Bot pushed a commit that referenced this pull request Feb 24, 2025
salvacorts pushed a commit that referenced this pull request Jul 11, 2025
salvacorts added a commit that referenced this pull request Jul 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport k239 backport release-3.4.x size/S type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories

2 participants