Skip to content

fix(operator): Select non-zero delete worker count for all sizes #16492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2025
Merged

fix(operator): Select non-zero delete worker count for all sizes #16492

merged 1 commit into from
Feb 28, 2025

Conversation

xperimental
Copy link
Collaborator

@xperimental xperimental commented Feb 27, 2025 •
edited
Loading

What this PR does / why we need it:

This change restructures the code used to select the amount of delete workers in the operator-generated configuration, so that there is always a non-zero number of workers.

Which issue(s) this PR fixes:

Fixes #16466 / LOG-6781

Special notes for your reviewer:

  • Still a draft until we have decided into which release this goes

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Tests updated
  • Title matches the required conventional commits format, see here
@xperimental xperimental self-assigned this Feb 27, 2025
@xperimental xperimental marked this pull request as ready for review February 28, 2025 14:59
JoaoBraveCoding
JoaoBraveCoding approved these changes Feb 28, 2025
View reviewed changes
Copy link
Collaborator

@JoaoBraveCoding JoaoBraveCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
@JoaoBraveCoding JoaoBraveCoding merged commit 1e5579a into grafana:main Feb 28, 2025
67 checks passed
@xperimental xperimental deleted the fix-pico-delete branch February 28, 2025 15:05
This was referenced Mar 5, 2025
Open
Merged
This was referenced Mar 17, 2025
Open
Open
Open
This was referenced Mar 31, 2025
Merged
Open
This was referenced Apr 14, 2025
Open
Open
@loki-gh-app loki-gh-app bot mentioned this pull request Apr 22, 2025
Open
This was referenced Apr 23, 2025
Merged
Merged
Merged
This was referenced May 5, 2025
Open
Open
This was referenced May 19, 2025
Open
Open
This was referenced May 26, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/operator size/S
2 participants
@xperimental @JoaoBraveCoding