Skip to content

fix: increment UsageTracker.DiscardedBytesAdd() for ingestion policy discards #16528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

JordanRushing
Copy link
Contributor

@JordanRushing JordanRushing commented Mar 3, 2025

What this PR does / why we need it:

This PR adds calls to reportDiscardedDataWithTracker() in the Distributor when we discard logs for ingestion policy reasons which maintains consistency between UsageTracker and other discarded_byte metrics.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

N/A

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
…discards

Signed-off-by: Jordan Rushing <rushing.jordan@gmail.com>
@JordanRushing JordanRushing self-assigned this Mar 3, 2025
@JordanRushing JordanRushing requested a review from a team as a code owner March 3, 2025 19:39
@JordanRushing JordanRushing merged commit a4c796d into grafana:main Mar 7, 2025
58 checks passed
JoaoBraveCoding pushed a commit to JoaoBraveCoding/loki that referenced this pull request Mar 12, 2025
…discards (grafana#16528)

Signed-off-by: Jordan Rushing <rushing.jordan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 participants