feat: when using sqlite for storing delete requests, use the stored completion time to reduce the requests considered for querytime filtering #16600
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The compactor continues to do query time filtering of delete requests even after they have been marked as processed. Ideally, it should stop query time filtering of requests that have been in the processed state for a while to let the index updates propagate to the indexgateways. However,
boltdb
did not have the timestamp for when the request was processed, and it was hard to introduce it.We recently added support for `SQLite' as a database for storing delete requests, which also stores their completion time. This PR adds support for eliminating delete requests from query time filtering if it's been a while since they were marked as processed. This should reduce some resource usage on the compactor and queries by eliminating unnecessary work.
Checklist