Skip to content

fix: zeroed stream hash when checking limits #16729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

grobinson-grafana
Copy link
Contributor

@grobinson-grafana grobinson-grafana commented Mar 13, 2025

What this PR does / why we need it:

This pull request fixes a zero stream hash when checking limits as the check was using logproto.PushRequest that had a zeored hash.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@grobinson-grafana grobinson-grafana requested a review from a team as a code owner March 13, 2025 09:02
@grobinson-grafana grobinson-grafana force-pushed the grobinson/fix-zeroed-stream-hash-checking-limits branch 2 times, most recently from f15f331 to a06a562 Compare March 13, 2025 09:14
@grobinson-grafana grobinson-grafana changed the title Fix zerod stream hash when checking limits Mar 13, 2025
@grobinson-grafana grobinson-grafana force-pushed the grobinson/fix-zeroed-stream-hash-checking-limits branch from a06a562 to 654b746 Compare March 13, 2025 09:21
@grobinson-grafana grobinson-grafana merged commit ab0cbce into main Mar 13, 2025
60 checks passed
@grobinson-grafana grobinson-grafana deleted the grobinson/fix-zeroed-stream-hash-checking-limits branch March 13, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 participants