Skip to content

feat: add dry-run mode for checking limits in distributors #16754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2025

Conversation

grobinson-grafana
Copy link
Contributor

@grobinson-grafana grobinson-grafana commented Mar 14, 2025

What this PR does / why we need it:

This pull request adds a dry-run mode for checking limits in distributors. It allows the distributors to call the ingest limits service and check if the request exceeds limits, without rejecting requests that are exceeding limits.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@grobinson-grafana grobinson-grafana requested a review from a team as a code owner March 14, 2025 09:40
@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Mar 14, 2025
@grobinson-grafana grobinson-grafana force-pushed the grobinson/add-dry-run-mode-ingest-limits branch from 477264b to d82d736 Compare March 14, 2025 09:41
This commit adds a dry-run mode for checking limits in distributors.
It allows the distributors to call the ingest limits service and
check if the request exceeds limits, without rejecting requests that
are exceeding limits.
@grobinson-grafana grobinson-grafana force-pushed the grobinson/add-dry-run-mode-ingest-limits branch from d82d736 to 0bff2e3 Compare March 14, 2025 09:46
Copy link
Contributor

github-actions bot commented Mar 14, 2025

💻 Deploy preview deleted.

@grobinson-grafana grobinson-grafana merged commit d6c499b into main Mar 14, 2025
62 checks passed
@grobinson-grafana grobinson-grafana deleted the grobinson/add-dry-run-mode-ingest-limits branch March 14, 2025 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
2 participants