fix: canary only worked when gateway enabled - #16758
Merged
JStickler merged 6 commits intoJun 2, 2025
Merged
Conversation
jacobcrawford
force-pushed
the
bugfix-canary-only-worked-when-gateway-enabled
branch
from
March 14, 2025 10:44
fca1d8e to
7c00dd0
Compare
jacobcrawford
marked this pull request as ready for review
March 14, 2025 10:46
JStickler
reviewed
Mar 14, 2025
jacobcrawford
force-pushed
the
bugfix-canary-only-worked-when-gateway-enabled
branch
from
April 17, 2025 05:27
7c00dd0 to
a7be443
Compare
Contributor
Author
|
@JStickler is anything holding us back from completing this PR? |
Contributor
Author
|
@slim-bean or @knylander-grafana maybe one of you can review this super small PR. We are a company that would really appreciate being able to use the loki-canary deployment 😄 |
Contributor
Author
|
@slim-bean thank you for the review! 😄 |
Collaborator
|
yeah we have to restrict running workflows to be approved by maintainers and we are also the only folks with merge access. I just kicked off CI will try to merge it as soon as it finishes! |
This was referenced Aug 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The Loki Canary only worked when the gateway was enabled. We should support setting the Loki endpoint through values so it does not have as hard dependency to the gateway.
Which issue(s) this PR fixes:
Fixes #14233
Fixes #11208
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR