feat(helm): add tpl support for pattern_ingester and ingester_client - #16759
Merged
Jayclifford345 merged 16 commits intoAug 4, 2025
Conversation
Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
…s/loki into helm_improve_pattern_ingester Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
…pattern_ingester Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
…pattern_ingester Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
QuentinBisson
left a comment
QuentinBisson
left a comment
Contributor
There was a problem hiding this comment.
LGTM @JStickler
Thanks for the contribution @paulojmdias
6 tasks
Contributor
8 tasks
Signed-off-by: Paulo Dias <44772900+paulojmdias@users.noreply.github.com>
Contributor
Author
|
@jkroepke done, please review 🙌 I also rebased the branch and updated the last CHANGELOG.md entry which has the PR reference missing. |
Signed-off-by: Paulo Dias <44772900+paulojmdias@users.noreply.github.com>
Jayclifford345
enabled auto-merge (squash)
August 4, 2025 13:18
This was referenced Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #15464
Fixes #12054
Fixes #18652
Special notes for your reviewer:
ingester_clientcomes from feat(helm): Add missing server config ingester_client #12054 and seems abandoned.pattern_ingesterdoes not break any current deployment.compactor_grpc_clientconfigurationChecklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR