Skip to content

fix: fixes a data race I added changing this to a map #16814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 18, 2025

Conversation

grobinson-grafana
Copy link
Contributor

@grobinson-grafana grobinson-grafana commented Mar 18, 2025

What this PR does / why we need it:

This commit fixes a data race I added to getConsumedPartitions changing it from a slice to a map. This changes it back, avoiding the need to use a mutex as the size is calculated ahead of time and we don't use append.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@grobinson-grafana grobinson-grafana requested a review from a team as a code owner March 18, 2025 14:36
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This commit fixes a data race I added to getConsumedPartitions changing
it from a slice to a map. This changes it back, avoiding the need to
use a mutex as the size is calculated ahead of time and we don't use
append.
@grobinson-grafana grobinson-grafana force-pushed the grobinson/fix-data-race-limits-frontend branch from 2eac586 to 110f010 Compare March 18, 2025 14:40
@grobinson-grafana grobinson-grafana merged commit f4893ee into main Mar 18, 2025
60 checks passed
@grobinson-grafana grobinson-grafana deleted the grobinson/fix-data-race-limits-frontend branch March 18, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 participants