feat: return all reasons a stream was rejected from the frontend #16826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the frontend to return all reasons a stream was rejected. For example, in the case where a stream was both rate limited and exceeded the maximum number of active streams, both of these errors will now be returned in the same response.
| f.metrics.tenantRejectedStreams.WithLabelValues( | ||
| req.Tenant, | ||
| ReasonExceedsMaxStreams, | ||
| ).Add(float64(len(rejectedStreams))) |
There was a problem hiding this comment.
It's OK to add 0 here I think, and avoids the need for another if statement.
periklis
approved these changes
Mar 19, 2025
grobinson-grafana
deleted the
grobinson/return-all-reasons-from-frontend
branch
periklis
pushed a commit
that referenced
this pull request
Mar 20, 2025
6 tasks
grobinson-grafana
added a commit
that referenced
this pull request
Mar 20, 2025
This was referenced May 19, 2025
This was referenced May 26, 2025
This was referenced Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This commit updates the frontend to return all reasons a stream was rejected. For example, in the case where a stream was both rate limited and exceeded the maximum number of active streams, both of these errors will now be returned in the same response.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR