Skip to content

feat: add evictor #16839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2025
Merged

feat: add evictor #16839

merged 1 commit into from
Mar 26, 2025

Conversation

grobinson-grafana
Copy link
Contributor

@grobinson-grafana grobinson-grafana commented Mar 19, 2025

What this PR does / why we need it:

This commit adds an evictor abstraction that will run the eviction of stale streams. The reason for abstracing it is two reasons:

  1. It is easier to test
  2. It will allow us to parallelize eviction over shards of metadata (for example, one per partition) to increase parallelism and reduce lock contention.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@grobinson-grafana grobinson-grafana requested a review from a team as a code owner March 19, 2025 17:36
@grobinson-grafana grobinson-grafana force-pushed the grobinson/add-evictor branch 2 times, most recently from da6c3e1 to 5c3e3ae Compare March 19, 2025 19:20
This commit adds an evictor abstraction that will run the eviction
of stale streams. The reason for abstracing it is two reasons:

1. It is easier to test
2. It will allow us to parallelize eviction over shards of metadata
   (for example, one per partition) to increase parallelism and
   reduce lock contention.
@grobinson-grafana grobinson-grafana merged commit eccdf45 into main Mar 26, 2025
61 checks passed
@grobinson-grafana grobinson-grafana deleted the grobinson/add-evictor branch March 26, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 participants