Skip to content

feat(distributor): Add MaxRecvMsgSize config for uncompressed message size limits - #16915

Merged
periklis merged 5 commits into
mainfrom
distibutor-max-recv-msg-size
Apr 1, 2025
Merged

feat(distributor): Add MaxRecvMsgSize config for uncompressed message size limits#16915
periklis merged 5 commits into
mainfrom
distibutor-max-recv-msg-size

Conversation

@periklis

@periklis periklis commented Mar 26, 2025

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:
This PR introduces a config option to control the max received message size for uncompressed data. The default is set to 100 MB. Previously the code base allowed up to 2 GB which per push request which is obviously a long-time hanging hindsight.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@periklis periklis added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Mar 26, 2025
@periklis periklis self-assigned this Mar 26, 2025
@periklis
periklis requested a review from a team as a code owner March 26, 2025 09:28
@github-actions

github-actions Bot commented Mar 26, 2025

Copy link
Copy Markdown
Contributor

💻 Deploy preview deleted.

@slim-bean

Copy link
Copy Markdown
Collaborator

nice! we should also increment our discard metrics, we can't increment the discard lines metric because we don't have lines yet, but I think we should implement the discard bytes with a new reason code? WDYT?

@pull-request-size pull-request-size Bot added size/L and removed size/M labels Mar 27, 2025
@periklis
periklis merged commit 1d99f4d into main Apr 1, 2025
@periklis
periklis deleted the distibutor-max-recv-msg-size branch April 1, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories

3 participants