Skip to content

feat: Meta Monitoring Loki v2 (Part 2) - Loki Mixin's - #16962

Merged
poyzannur merged 15 commits into
mainfrom
loki-mixins-update
Apr 3, 2025
Merged

feat: Meta Monitoring Loki v2 (Part 2) - Loki Mixin's#16962
poyzannur merged 15 commits into
mainfrom
loki-mixins-update

Conversation

@Jayclifford345

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
This moves the meta-monitoring responsibilities from: https://github.com/grafana/meta-monitoring-chart
to the widely supported: https://github.com/grafana/k8s-monitoring-helm.

This is a 3-part PR:

This PR updated Loki mixin regex to support the new k8s monitoring helm.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@Jayclifford345
Jayclifford345 requested a review from a team as a code owner March 31, 2025 12:51

@poyzannur poyzannur left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you'll see i have the same comment for all examples for pod/container changes
please take a look. i suggest we revert back to more inclusive version with regex.

we can take it offline on how to proceed.

Comment thread production/loki-mixin-compiled-ssd/dashboards/loki-logs.json Outdated
Comment thread production/loki-mixin-compiled-ssd/dashboards/loki-logs.json Outdated
Comment thread production/loki-mixin-compiled/dashboards/loki-operational.json Outdated
@Jayclifford345

Jayclifford345 commented Apr 3, 2025

Copy link
Copy Markdown
Contributor Author

Hey @poyzannur, I think I caught them all. I left each as regex since most are configured by the dashboard variables. Should we consider changing how those operate? Or are we happy to leave them as is? i.e make the pod variables multi select

@Jayclifford345

Copy link
Copy Markdown
Contributor Author

@poyzannur, that is the log changes we discussed in and ready for review

@Jayclifford345
Jayclifford345 requested a review from poyzannur April 3, 2025 12:56
@poyzannur
poyzannur merged commit 93360f6 into main Apr 3, 2025
@poyzannur
poyzannur deleted the loki-mixins-update branch April 3, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants