feat: Meta Monitoring Loki v2 (Part 2) - Loki Mixin's - #16962
Merged
Conversation
This was referenced Mar 31, 2025
poyzannur
reviewed
Apr 2, 2025
poyzannur
left a comment
Collaborator
There was a problem hiding this comment.
you'll see i have the same comment for all examples for pod/container changes
please take a look. i suggest we revert back to more inclusive version with regex.
we can take it offline on how to proceed.
Contributor
Author
|
Hey @poyzannur, I think I caught them all. I left each as regex since most are configured by the dashboard variables. Should we consider changing how those operate? Or are we happy to leave them as is? i.e make the pod variables multi select |
Contributor
Author
|
@poyzannur, that is the log changes we discussed in and ready for review |
poyzannur
approved these changes
Apr 3, 2025
This was referenced May 26, 2025
This was referenced Jun 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This moves the meta-monitoring responsibilities from: https://github.com/grafana/meta-monitoring-chart
to the widely supported: https://github.com/grafana/k8s-monitoring-helm.
This is a 3-part PR:
This PR updated Loki mixin regex to support the new k8s monitoring helm.
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR