feat: add metric to track ingest limits failures in distributor #17015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grobinson-grafana
force-pushed
the
grobinson/add-metric-to-track-limits-failures
branch
from
b14dcb0 to
45d5a0c
Compare
grobinson-grafana
changed the title
This commit adds a new metric loki_distributor_ingest_limits_failures_total that track the total number of failures encountered checking per-tenant limits. This is important to track, as when a failure happens, the request is accepted (fails-open).
grobinson-grafana
force-pushed
the
grobinson/add-metric-to-track-limits-failures
branch
from
45d5a0c to
0488279
Compare
rfratto
approved these changes
Apr 4, 2025
grobinson-grafana
deleted the
grobinson/add-metric-to-track-limits-failures
branch
This was referenced May 26, 2025
This was referenced Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This commit adds a new metric
loki_distributor_ingest_limits_failures_totalthat track the total number of failures encountered checking per-tenant limits. This is important to track, as when a failure happens, the request is accepted (fails-open).Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR