feat(helm): support templated loki.operational_config - #17045
Merged
Conversation
added 3 commits
April 6, 2025 21:01
Signed-off-by: Dmitry Ponomaryov <me@halje.ru>
Signed-off-by: Dmitry Ponomaryov <me@halje.ru>
Signed-off-by: Dmitry Ponomaryov <me@halje.ru>
|
|
github-actions
Bot
added
area/helm
type/docs
Contributor
Author
|
@owen-d PTAL when you have time 🙏 |
Contributor
Author
|
@Jayclifford345 hello, can you help with approve PR? |
Contributor
|
LGTM Context: https://grafana.com/docs/loki/latest/configure/#operational_config Similar to #17451 @iamhalje Could you please rebase the PR? |
Signed-off-by: Dmitry Ponomaryov <iamhalje@gmail.com>
Contributor
Author
|
@jkroepke done |
Signed-off-by: Dmitry Ponomaryov <iamhalje@gmail.com>
Contributor
Author
|
@jkroepke added link on PR in changelog |
Contributor
Author
|
@jkroepke updated, can be right now merged? |
Contributor
|
Unfortunately, i do not have merge power. But the PR is marked as LGTM, internal loki team take care soon. |
salvacorts
approved these changes
Jul 14, 2025
Contributor
|
@iamhalje If you could get the merge conflict resolved in the CHANGELOG I can get this merged. |
Contributor
Author
|
@JStickler hi, updated |
This was referenced Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds support for templated
loki.operational_configin the Helm chart, allowing users to render this section dynamically using Helm'stpl().Which issue(s) this PR fixes:
None
Special notes for your reviewer:
N/A
Checklist
CONTRIBUTING.mdguide (required)make helm-docs)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR