fix: avoid copying label values from tsdb unless required #17077
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We are seeing OOMKills on index gateways due to a huge amount of allocations from LabelValues method of tsdb index reader. It happens due to copying all the label values read from the tsdb. This problem arises when the label matchers have any negative matchers.
I have changed the code to avoid making a copy of the label values unless we want to send it back as a response. I have checked all the usages of that method, and the only place we need to copy the values is when the
LabelValues
method is called explicitly to get all the values.Here is the benchmark showing the difference in performance:
Special notes for your reviewer:
I introduced the copying of label values in PR #7502 to avoid corruption of values when the underlying tsdb is closed.