feat: support disabling the partition consumers cache #17318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -12,46 +11,6 @@ import ( | |||
| "github.com/grafana/loki/v3/pkg/util" | |||
| ) | |||
|
|
|||
| const ringStreamUsageTemplate = ` | |||
There was a problem hiding this comment.
I decided to remove this as I don't believe we ever used it. If you have strong opinions about keeping it let me know and I will add an All() map[K, V] method to the cache to support this HTML page. My preference is to remove it though.
grobinson-grafana
force-pushed
the
grobinson/support-disabling-partition-consumers-cache
branch
2 times, most recently
from
d88bfb1 to
e12184f
Compare
6 tasks
grobinson-grafana
force-pushed
the
grobinson/support-disabling-partition-consumers-cache
branch
2 times, most recently
from
50ae515 to
4798f18
Compare
github-actions
bot
added
the
type/docs
|
💻 Deploy preview deleted. |
grobinson-grafana
force-pushed
the
grobinson/support-disabling-partition-consumers-cache
branch
3 times, most recently
from
a293faa to
de7dfb7
Compare
This commit updates caching in the limits-frontend to support disabling the partition consumers cache via a no-op cache. We use a generic interface Cache[K comparable, V any] and provide two implementations, a TTLCache and a NopCache. The TTLCache is a much simpler implementation from our previous cache, and does not require goroutines to manage cache eviction. It does not support LRU as we do not need it.
grobinson-grafana
force-pushed
the
grobinson/support-disabling-partition-consumers-cache
branch
from
de7dfb7 to
f921504
Compare
periklis
approved these changes
Apr 18, 2025
grobinson-grafana
deleted the
grobinson/support-disabling-partition-consumers-cache
branch
This was referenced Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This pull request updates caching in the limits-frontend to support disabling the partition consumers cache via a no-op cache. We use a generic interface
Cache[K comparable, V any]and provide two implementations, aTTLCacheand aNopCache. TheTTLCacheis a much simpler implementation from our previous cache, and does not require goroutines to manage cache eviction. It does not support LRU as we do not need it.This pull request is stacked on top of #17315.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR