Skip to content

fix: improve structured metadata label normalization performance #17332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 20, 2025

Conversation

slim-bean
Copy link
Collaborator

What this PR does / why we need it:

Currently we normalize all the structured metadata label names to make them prometheus safe during pipeline execution, this results in us running the normalization code again and again for the same labels.

This PR moves this normalization to when we deserialize the interned string data so it is only done one time.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@slim-bean slim-bean requested a review from a team as a code owner April 18, 2025 17:35
Copy link
Member

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left some comments for you to consider, but they're not blocking

@slim-bean slim-bean merged commit 87922da into main Apr 20, 2025
61 checks passed
@slim-bean slim-bean deleted the optimize-structured-metadata-normalization branch April 20, 2025 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 participants