feat(operator): allow users to configure virtual-host-style for S3 secrets - #17363
Merged
Conversation
JoaoBraveCoding
requested review from
a team,
periklis and
xperimental
as code owners
April 21, 2025 15:22
xperimental
reviewed
Apr 23, 2025
xperimental
left a comment
xperimental
left a comment
Collaborator
There was a problem hiding this comment.
This seems to work great, left a comment if we should further simplify it (if I have not forgotten something).
Thanks for cleaning up the docs a bit as well 👍
Co-authored-by: Robert Jacob <rojacob@redhat.com> Signed-off-by: Joao Marcal <jmarcal@redhat.com>
xperimental
approved these changes
Apr 25, 2025
xperimental
left a comment
xperimental
left a comment
Collaborator
There was a problem hiding this comment.
Works great, approving. 👍
I have left two comments on the PR, I think I'd consider them "optional".
xperimental
reviewed
Apr 28, 2025
Co-authored-by: Robert Jacob <rojacob@redhat.com> Signed-off-by: Joao Marcal <jmarcal@redhat.com>
xperimental
approved these changes
Apr 29, 2025
This was referenced Jul 21, 2025
This was referenced Aug 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
https://issues.redhat.com/browse/LOG-6641
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR