Conversation
UI build was broken as of #17201. The resolvers update no longer requires type inference when using useForm.
rfratto
commented
May 15, 2025
| const [openRows, setOpenRows] = useState<Set<string>>(new Set()); | ||
|
|
||
| const form = useForm<z.infer<typeof formSchema>>({ | ||
| const form = useForm({ |
Member
Author
There was a problem hiding this comment.
This line (and line 156) are the only changes to the code. Everything else is either:
- My dev environment reordering imports using Prettier
- The new UI build
grobinson-grafana
approved these changes
May 15, 2025
This was referenced Jul 21, 2025
This was referenced Aug 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UI build was broken as of #17201. The resolvers update no longer requires type inference when using useForm.
This also adds a GitHub Action workflow to test building the UI so we can catch this earlier.