feat(kafka): Support multiple kafka clients in component - #17757
Merged
Conversation
| } | ||
|
|
||
| func (cfg *ClientConfig) RegisterFlagsWithPrefix(prefix string, f *flag.FlagSet) { | ||
| f.StringVar(&cfg.Address, prefix+".address", "localhost:9092", "The Kafka backend address.") |
Contributor
There was a problem hiding this comment.
Remember to fix duplicate defaults.
grobinson-grafana
approved these changes
May 20, 2025
grobinson-grafana
left a comment
grobinson-grafana
left a comment
Contributor
There was a problem hiding this comment.
👍 Please see comments but otherwise I don't need to see this again, thanks!
As discussed on Slack, please make sure to update this configuration in all of our environments and then come back and remove the deprecated fields. May I suggest creating an issue for this so you don't forget about it?
This was referenced Jul 21, 2025
This was referenced Aug 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This pull request enables Loki components to use separate reader and writer clients in parallel. The separation of reader/writer address and client ID is required for kafka-compatible implementations that provide different endpoints for writes and reads.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR