Skip to content

fix(kafka): Disable address defaults - #17825

Merged
periklis merged 1 commit into
mainfrom
fix-kafka-address-defaults
May 26, 2025
Merged

fix(kafka): Disable address defaults#17825
periklis merged 1 commit into
mainfrom
fix-kafka-address-defaults

Conversation

@periklis

@periklis periklis commented May 26, 2025

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:
This PR disables the defaults in the kafka address config until transitioning is compliete

Which issue(s) this PR fixes:
Fixes #grafana/loki-private/issues/1663

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@periklis
periklis requested a review from a team as a code owner May 26, 2025 18:09
@periklis
periklis enabled auto-merge (squash) May 26, 2025 18:10
@periklis periklis self-assigned this May 26, 2025
@periklis periklis changed the title fix(kafka): Disable defaults address defaults May 26, 2025
@periklis periklis added type/bug Somehing is not working as expected backport k256 and removed backport k256 type/bug Somehing is not working as expected labels May 26, 2025
@periklis
periklis merged commit 51312af into main May 26, 2025
@periklis
periklis deleted the fix-kafka-address-defaults branch May 26, 2025 18:17
loki-gh-app Bot pushed a commit that referenced this pull request May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport k256 size/XS type/bug Somehing is not working as expected

2 participants