Skip to content

fix: Return defaults for non-existant tenants on applied limits endpoint - #17942

Merged
salvacorts merged 2 commits into
mainfrom
salvacorts/config-self-serve/return-default-limits
Jun 3, 2025
Merged

fix: Return defaults for non-existant tenants on applied limits endpoint#17942
salvacorts merged 2 commits into
mainfrom
salvacorts/config-self-serve/return-default-limits

Conversation

@salvacorts

@salvacorts salvacorts commented Jun 2, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Before this PR, when a tenant didn't have an explicit override, the endpoint would return a 404. we fix this by returning the default limits instead.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@salvacorts
salvacorts marked this pull request as ready for review June 3, 2025 14:36
@salvacorts
salvacorts requested a review from a team as a code owner June 3, 2025 14:36
@salvacorts
salvacorts enabled auto-merge (squash) June 3, 2025 14:49
@salvacorts
salvacorts merged commit aaa0921 into main Jun 3, 2025
@salvacorts
salvacorts deleted the salvacorts/config-self-serve/return-default-limits branch June 3, 2025 15:05
@salvacorts salvacorts added type/bug Somehing is not working as expected backport k257 labels Jun 4, 2025
loki-gh-app Bot pushed a commit that referenced this pull request Jun 4, 2025
@salvacorts grafana-delivery-bot[bot]
fix: Return defaults for non-existant tenants on applied limits endpo…
c1a32a8 
…int (#17942)

(cherry picked from commit aaa0921)
@loki-gh-app loki-gh-app Bot mentioned this pull request Jun 4, 2025
Merged
6 tasks
This was referenced Aug 5, 2025
Closed
Closed
@loki-gh-app loki-gh-app Bot mentioned this pull request Aug 18, 2025
Closed
@loki-gh-app loki-gh-app Bot mentioned this pull request Sep 1, 2025
Closed
@loki-gh-app loki-gh-app Bot mentioned this pull request Sep 8, 2025
Closed
@loki-gh-app loki-gh-app Bot mentioned this pull request Sep 15, 2025
Closed
@loki-gh-app loki-gh-app Bot mentioned this pull request Sep 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport k257 size/XS type/bug Somehing is not working as expected

2 participants

@salvacorts @paul1r