Skip to content

fix: Fix nil pointer dereference in Volume method of the composite store - #18064

Merged
chaudum merged 3 commits into
mainfrom
chaudum/fix-nil-pointer-exception
Jun 11, 2025
Merged

fix: Fix nil pointer dereference in Volume method of the composite store#18064
chaudum merged 3 commits into
mainfrom
chaudum/fix-nil-pointer-exception

Conversation

@chaudum

@chaudum chaudum commented Jun 11, 2025

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

If err is nil then calling the method Error() on it causes a nil pointer dereference.

@chaudum
chaudum requested a review from a team as a code owner June 11, 2025 12:26
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
@chaudum
chaudum force-pushed the chaudum/fix-nil-pointer-exception branch from 2062a13 to 3fdf5ce Compare June 11, 2025 12:28

@shantanualsi shantanualsi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chaudum chaudum added type/bug Somehing is not working as expected backport k258 labels Jun 11, 2025
@chaudum
chaudum enabled auto-merge (squash) June 11, 2025 13:19
@chaudum
chaudum merged commit fc7c018 into main Jun 11, 2025
@chaudum
chaudum deleted the chaudum/fix-nil-pointer-exception branch June 11, 2025 13:26
loki-gh-app Bot pushed a commit that referenced this pull request Jun 11, 2025
…ore (#18064)

If err is nil then calling the method Error() on it causes a nil pointer dereference.

Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
(cherry picked from commit fc7c018)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport k258 size/XS type/bug Somehing is not working as expected

3 participants