feat: return metric query partial results for drilldown - #18286
Merged
Conversation
matyax
reviewed
Jul 1, 2025
| if httpreq.IsLogsDrilldownRequest(ctx) { | ||
| // For Logs Drilldown requests, return partial results with warning | ||
| vec = vec[:maxSeries] | ||
| metadata.FromContext(ctx).AddWarning(fmt.Sprintf("maximum number of series (%d) reached for a single query; returning partial results", maxSeries)) |
paul1r
approved these changes
Jul 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR changes the behavior of the max series limitation for metric queries sent from drilldown, allowing those queries to receive partial results with a warning rather than nothing and a 500. The reason we don't do this for all queries is because it introduces non-determininistic results. However, in drilldown we've determined partial results are much more helpful to the user than no results, and still help them drilldown to the logs they care about. Once they've narrowed down what they are looking for, they can switch to explore for deterministic results.
This is very useful for both persisted patterns as well as the histograms for detected fields, both of which can produce more than the limit, but are examples where having some results that my change from query to query is better than having no results that are deterministic.
Which issue(s) this PR fixes:
Fixes #18213 grafana/logs-drilldown#1355
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR