fix(ci): Fix lambda-promtail image build - #18443
Merged
Merged
Conversation
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
The go.mod file referenced the github.com/grafana/loki/v3 dependency with a relative path `../../` that is outside of the scope of the Docker file. Instead, this change updates Loki to `@latest` (commit d446d47). Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
chaudum
commented
Jul 14, 2025
| @@ -1,4 +1,6 @@ | |||
| FROM golang:1.24-alpine AS build-image | |||
| ARG GO_VERSION=1.24 | |||
Contributor
Author
There was a problem hiding this comment.
GO_VERSION is passed as build arg, see https://github.com/grafana/loki/actions/runs/16257626478/job/45906161654#step:11:189
chaudum
enabled auto-merge (squash)
July 14, 2025 08:11
salvacorts
approved these changes
Jul 14, 2025
This was referenced Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The CI workflow was failing since a while, e.g. https://github.com/grafana/loki/actions/runs/16257626478/job/45906161654