fix: Fix handling of duplicate delete requests - #18460
Merged
Merged
Conversation
…already processed
… impacted from sql query which updates the data
poyzannur
approved these changes
Jul 16, 2025
This was referenced Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Due to a bug in the code, we would not skip requests detected as duplicates and still process them. This would also lead to marking the shards of duplicate delete requests as processed multiple times.
Marking the same delete request shards as processed in SQLite would lead to an incorrect processed shard count and leave the consolidated delete request record in an unprocessed state forever, even though all its shards would be processed. The reason is that we mark the consolidated delete request record as completed when the processed shard count is equal to the total shard count.
I want to point out that this bug does not impact the functioning of the compactor or the processing of delete requests. The compactor will continue to process the remaining shards of the request. It is just that the tenant would feel that their delete requests are stuck in processing.
In this PR, I am fixing the bug, which includes the following changes:
Special notes for your reviewer:
This bug does not impact the functioning of the compactor or the processing of delete requests. The compactor will continue to process the remaining shards of the request.
Checklist