feat: Goldfish UI Improvements - #18504
Merged
Merged
Conversation
commit 700e3896daec3069e1a377e8d6c4d75bdc55e221
Author: Trevor Whitney <trevorjwhitney@gmail.com>
Date: Wed Jul 23 14:30:16 2025 -0600
chore: update branch against origin/main
commit 5177df16db5df51240533db51fb5839a169851c2
Author: Trevor Whitney <trevorjwhitney@gmail.com>
Date: Wed Jul 23 14:24:49 2025 -0600
chore: fix linting issues
This PR also fixes Makefile tasks to work with claude-code and git worktrees.
commit e78552c9ecc232896b2d555e3fc654f8580a9df2
Author: Trevor Whitney <trevorjwhitney@gmail.com>
Date: Wed Jul 23 13:58:26 2025 -0600
fix: update go module dependencies and lint fixes
- Move DATA-DOG/go-sqlmock from indirect to direct dependency as it's used in goldfish tests
- Fix whitespace formatting in goldfish.go
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
commit 6f2015f
Author: Trevor Whitney <trevorjwhitney@gmail.com>
Date: Fri Jul 18 17:14:48 2025 -0600
feat: various performance and ux improvements for goldfish page
commit 792c2fa
Author: Trevor Whitney <trevorjwhitney@gmail.com>
Date: Fri Jul 18 14:50:22 2025 -0600
feat: switch between all, match, mismatch, error outcomes
commit 3e201e3
Author: Trevor Whitney <trevorjwhitney@gmail.com>
Date: Thu Jul 17 17:07:09 2025 -0600
chore: clean up comment
commit e8e84b5
Author: Trevor Whitney <trevorjwhitney@gmail.com>
Date: Thu Jul 17 17:06:12 2025 -0600
chore: lint fixes
commit 2560d20
Author: Trevor Whitney <trevorjwhitney@gmail.com>
Date: Thu Jul 17 17:01:13 2025 -0600
chore: lint and format
commit 8773315
Author: Trevor Whitney <trevorjwhitney@gmail.com>
Date: Thu Jul 17 16:40:31 2025 -0600
chore: recompile javascript assets
commit c3b85d6
Author: Trevor Whitney <trevorjwhitney@gmail.com>
Date: Thu Jul 17 16:16:37 2025 -0600
feat: goldfish UI
trevorwhitney
force-pushed
the
goldfish-ui-comparisons
branch
from
July 23, 2025 20:33
700e389 to
3b41c96
Compare
trevorwhitney
marked this pull request as ready for review
July 23, 2025 20:34
DylanGuedes
approved these changes
Jul 23, 2025
trevorwhitney
enabled auto-merge (squash)
July 23, 2025 21:32
trevorwhitney
disabled auto-merge
July 23, 2025 21:32
This was referenced Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR follows up on #17983 and provides various UX and performance filtering such as
This PR also includes a few improvements for using
claude-codein this repo, such asIt also adds tests for the frontend and a test suite to run them.
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR