feat(helm): Add health probes to gateway component - #18545
Conversation
jkroepke
left a comment
jkroepke
left a comment
There was a problem hiding this comment.
Thanks for your PR, please check comments.
| @@ -1178,13 +1178,17 @@ gateway: | |||
| {{- end }} | |||
| # -- Existing basic auth secret to use. Must contain '.htpasswd' | |||
| existingSecret: null | |||
| # -- liveness probe for the nginx container in the gateway pods. | |||
| livenessProbe: {} | |||
There was a problem hiding this comment.
What did you think about set
livenessProbe:
httpGet:
path: /loki/api/v1/status/buildinfo
port: http-metrics
initialDelaySeconds: 15
timeoutSeconds: 1as well?
There was a problem hiding this comment.
My intention was to create a PR that makes the probes configurable but do not change any behavior, so it does not become a breaking change and have to wait until the next major release to be merged.
But if you prefer to also configure sensible probes wherever possible, that's fine by be. Do you want me to add the suggested probes?
There was a problem hiding this comment.
@Jayclifford345 WDYT?
Loki Operator uses
loki/operator/internal/manifests/var.go
Line 34 in ce03b79
by default
There was a problem hiding this comment.
@jkroepke I've completely lost track of this PR. Is it in a good state or no?
This change makes it possibe to configure `livenessProbe` and `startupProbe` to the nginx container in the gateway pods. Also adds a guard for when the `readinessProbe` is unset. Signed-off-by: Andreas Lindhé <7773090+lindhe@users.noreply.github.com>
Done via the following command: ```shell docker run -it --rm -v "$(pwd):/go" --entrypoint bash -e BUILD_IN_CONTAINER=false grafana/loki-build-image:0.34.6 -c 'git config --global --add safe.directory /go; make -BC docs sources/setup/install/helm/reference.md' ``` Signed-off-by: Andreas Lindhé <7773090+lindhe@users.noreply.github.com>
Co-authored-by: Jan-Otto Kröpke <mail@jkroepke.de> Signed-off-by: Andreas Lindhé <7773090+lindhe@users.noreply.github.com>
dd77a88 to
4e99a09
Compare
4 participants
What this PR does / why we need it:
This change makes it possibe to configure
livenessProbeandstartupProbeto the nginx container in the gateway pods. Also adds a guard for when thereadinessProbeis unset.Which issue(s) this PR fixes:
Partially addresses #13678
Special notes for your reviewer:
Partially replaces #15359
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR